[ws-manager-bridge] update prebuild state properly #7968
Conversation
roboquat
added
do-not-merge/work-in-progress
do-not-merge/release-note-label-needed
team: webapp
Codecov Report
@@ Coverage Diff @@
## main #7968 +/- ##
==========================================
- Coverage 11.46% 10.20% -1.27%
==========================================
Files 20 18 -2
Lines 1177 1009 -168
==========================================
- Hits 135 103 -32
+ Misses 1039 905 -134
+ Partials 3 1 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@AlexTugarev Is this ready for review or still WIP? 🙏🏽 |
roboquat
added
release-note
and removed
do-not-merge/work-in-progress
do-not-merge/release-note-label-needed
labels
| @@ -325,7 +325,7 @@ export class WorkspaceManagerBridge implements Disposable { | |||
| // prebuilds are an EE feature - we just need the hook here | |||
| } | |||
|
|
|||
| protected async controlPrebuildInstance(instance: WorkspaceInstance): Promise<void> { | |||
| protected async stopPrebuildInstance(ctx: TraceContext, instance: WorkspaceInstance): Promise<void> { | |||
There was a problem hiding this comment.
renaming, because this function is called in a single context, i.e. only when the status of a prebuild workspace instance is adjusted.
|
LGTM label has been added. Git tree hash: 86f41e456efc10d99a7562c76e8fdb18bfa21550
|
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: laushinka Associated issue requirement bypassed by: laushinka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ws-manager-bridgeis periodically checking for the actual state of prebuilds which according to entries in the DB should be running.this PR adds missing state updates to prebuild infos which are derived from workspaces instances.